breaking(transport): Make HTTP2Transport the default #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4492 +/- ##
==============================================
+ Coverage 84.75% 84.85% +0.09%
==============================================
Files 158 158
Lines 16093 16093
Branches 2564 2564
==============================================
+ Hits 13640 13656 +16
+ Misses 1660 1648 -12
+ Partials 793 789 -4
|
|
The test failures look unrelated and consistent with each other. |
|
ty @BYK, will take over and fix the tests. will also make this a draft till we're ready to merge! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sentrivana
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Thanks @BYK, this lgtm. Two things:
- please check out the Cursor comment about still setting the option via experiments in one of the tests, afait this is actually an oversight
- please add a note about this to the MIGRATION_GUIDE
I'll take some time this week to also add this to the migration guide in the docs, together with the async transport.
BYK
commented
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the HTTP2 transport the default when
h2andhttpcorepackages are installed. We've been testing this on Sentry SaaS for a while without any issues.We should promote installing the SDK as
sentry-sdk[http2]for this to be picked up though. Since we still have to support Python 3.7 andh2not being supported there, we cannot install it by default and use HTTP2 directly.EDIT: please merge after potel dogfooding